chore: Remove clear_namespace script #3519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #3350 the MDC is attached to an etcd lease, so it cleans up on shutdown. We don't need to manually clear namespace any more. If there are any remaining non-lease keys (I'm not aware of any, and I have looked), we will treat that as a bug. Signed-off-by: Graham King <[email protected]>
WalkthroughRemoved the clear_namespace utility and all its invocations. Launch scripts for sglang and trtllm now start ingress/frontend and workers without a pre-clean step. The Python CLI modules, Rust runtime method, and Python bindings exposing temp_clear_namespace were deleted. Documentation and a test script were updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Op as Operator
participant L as Launch Script
participant F as Frontend/Ingress
participant W as Worker(s)
rect rgba(230,245,255,0.5)
note over L: Previous flow
Op->>L: Run script
L->>L: Clear namespace (removed)
L->>F: Start frontend/ingress
L->>W: Start worker(s)
end
rect rgba(235,255,235,0.5)
note over L: New flow
Op->>L: Run script
L--xL: Clear namespace (skipped)
L->>F: Start frontend/ingress
L->>W: Start worker(s)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (20)
💤 Files with no reviewable changes (19)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ishandhanani
approved these changes
Oct 9, 2025
rmccorm4
approved these changes
Oct 9, 2025
ziqifan617
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Graham King <[email protected]>
nv-tusharma
pushed a commit
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Graham King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3350 the MDC is attached to an etcd lease, so it cleans up on shutdown. We don't need to manually clear namespace any more.
If there are any remaining non-lease keys (I'm not aware of any, and I have looked), we will treat that as a bug.
Summary by CodeRabbit